October package fixes #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We replace R_alloc with a macro that just invokes malloc(), but malloc() has a return type of void*, while R_alloc has a return type of void*.
As far as I can tell the object argument has no effect on
dispatch!
That is:
NextMethod('[')
NextMethod('[', 'foobar')
NextMethod('[', stop('foooo!'))
Are equivalent.
Also, change platform name to linux-gnu. I'm not sure what this is used for, but Renjin's toolchain behaves more like linux-gnu than mingw32.
This value is expected by the nlme package and perhaps others.
The package may look for the file via the methods package or otherwise.
Renjin has modelled attributes as a map for some time. This makes sense to me, but in fact there appears to be a fair bit of code that relies on attribute order.
'Binary' format is a deprecated serialization format that uses native byte order. XDR format uses big-endian order on all platforms.
This help us achieve byte-for-byte compatibility with GNU R 3.5.3 serialization.
This help us achieve byte-for-byte compatibility with GNU R 3.5.3 serialization.
* Default row.names for a data.table are actually stored as an integer vector, not a character vector. * They are only converted to character strings when accessed via the row.names() function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.