Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Notion Notes and API keys #177

Merged
merged 12 commits into from
Oct 8, 2021

Conversation

alb
Copy link
Contributor

@alb alb commented Oct 6, 2021

This PR adds support for Notion's:

  • Individual and Team Notes
  • API Keys for Notion Integrations

@alb
Copy link
Contributor Author

alb commented Oct 6, 2021

@bee-san quick question:
Should I squash the commits into one or is it fine as is?

pywhat/Data/regex.json Outdated Show resolved Hide resolved
@bee-san
Copy link
Owner

bee-san commented Oct 6, 2021

You're fine with not squashing :)

@bee-san
Copy link
Owner

bee-san commented Oct 6, 2021

Can you delete the URLs on the other ones too please? :)

@alb
Copy link
Contributor Author

alb commented Oct 6, 2021

Can you delete the URLs on the other ones too please? :)

Which other ones? The Team or standard notes?

@bee-san
Copy link
Owner

bee-san commented Oct 7, 2021

Maybe I didn't explain myself right. The URL is used for printing.

So the code will run with:

pywhat https://notion.so/My-Note-ha45346d9dd4421abc6857ce4e7fb0db

Matched text: https://notion.so/My-Note-ha45346d9dd4421abc6857ce4e7fb0db
URL: https://www.notion.so/

PyWhat will then print:

$ pywhat https://notion.so/My-Note-ha45346d9dd4421abc6857ce4e7fb0db
https://www.notion.so/https://notion.so/My-Note-ha45346d9dd4421abc6857ce4e7fb0db

Now click on this link: https://www.notion.so/https://notion.so/My-Note-ha45346d9dd4421abc6857ce4e7fb0db

As you can see, it's not valid.

If your URL is google.com, it will append the matched text to the end of the URL. Hope that helps :)

@alb
Copy link
Contributor Author

alb commented Oct 7, 2021

@bee-san hope I got this right this time around 😅
I removed the URL from the personal note as well. This way it should match the full notion URI without adding any extra text.

pywhat/Data/regex.json Outdated Show resolved Hide resolved
pywhat/Data/regex.json Outdated Show resolved Hide resolved
pywhat/Data/regex.json Outdated Show resolved Hide resolved
@bee-san bee-san enabled auto-merge (squash) October 8, 2021 13:37
@bee-san bee-san merged commit 61bf3f7 into bee-san:main Oct 8, 2021
@alb alb deleted the notion_detection branch October 8, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants