This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Scroll loading of pools #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/beefyfinance/beefy-app/nu8udrrhh |
9ineMile
force-pushed
the
10CowsAtATime
branch
from
d9508ef
to
be70cb2
Compare
|
I'll close #140 with this PR. It might be enough of a performance boost. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load pools in chunks of 10 when scrolling.
Doesn't entirely fix #140 as the DOM can still grow very large if you scroll to the bottom with no filters, but speeds up the initial load.
Full windowing of the pools is a bit of a pain because of the dynamic pool height.