Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] beesdoo_shift_welcome_screen: new module #288

Merged
merged 6 commits into from
Mar 29, 2022
Merged

Conversation

tfrancoi
Copy link
Contributor

Add a module for cooperator welcome screen

  • Scan your member card

  • See if you can shop

  • See your counter and status

  • See your eater

  • See your next shift

@tfrancoi tfrancoi added the Polln label Feb 24, 2022
@tfrancoi tfrancoi mentioned this pull request Feb 24, 2022
beesdoo_shift_welcome_screen/models/welcome.py Outdated Show resolved Hide resolved
beesdoo_shift_welcome_screen/models/welcome.py Outdated Show resolved Hide resolved
beesdoo_shift_welcome_screen/models/welcome.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #288 (071ab74) into 12.0 (b0121be) will decrease coverage by 0.34%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             12.0     #288      +/-   ##
==========================================
- Coverage   68.59%   68.25%   -0.35%     
==========================================
  Files         107      109       +2     
  Lines        3369     3402      +33     
  Branches      590      596       +6     
==========================================
+ Hits         2311     2322      +11     
- Misses        950      972      +22     
  Partials      108      108              
Impacted Files Coverage Δ
beesdoo_shift_welcome_screen/models/welcome.py 31.25% <31.25%> (ø)
beesdoo_shift_welcome_screen/models/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0121be...071ab74. Read the comment docs.

tfrancoi and others added 2 commits March 15, 2022 14:32
Add a module for cooperator welcome screen

- Scan your member card
- See if you can shop
- See your counter and status

- See your eater
- See your next shift
@vdewulf
Copy link

vdewulf commented Mar 29, 2022

Welcome Screen tested on oufticoop.test.coopiteasy.be
New user created "welcome@oufticoop.be" with the right to "Shifts - Planning" (in order to see the Menu).

Connected as welcome user.
New Menu "Shift Welcome". Cf. screenshot

  • TO TEST : scan a barcode.
    I just entered a barcode manually in the Cooperator field, it does not work.
    To be tested with a real scanner and a card.

  • Manual selection
    I selected a coop in the list (regular worker).
    The status "Can shop" is displayed, his name, his counter and the next shifts (the next generated in the system it seems).
    When the person in the list is an "eater", the name of the worker is displayed.
    If the person has some eaters, their name is also displayed.

Conclusion : it works fine but we need to test the real "scan".
I edited the translation, cf. PO file for French BE (in CIE task because po file not supported in github)
welcome_screen_cannot_shop
welcome_screen_can_shop
welcome_screen_empty

@polchampion
Copy link
Collaborator

polchampion commented Mar 29, 2022

Welcome Screen tested on bees.test.coopiteasy.be
Connected with admin (in order to see the Menu).
Tested with the scan for existing user.

FYI : Scan needs to be set up to be used aside of keyboard because it only works if the language is en_US. I changed my computer's language to en_US for it to work but then I can't use the keyboard in French (this is an unrelated issue).

Conclusion : it works.

Could be improved : when you select a cooperator in the list manually, then scan a barcode, it doesn't work (you need to click away first) :
screenshot-bees test coopiteasy be-2022 03 29-15_26_51

@robinkeunen robinkeunen self-requested a review March 29, 2022 13:32
@polchampion
Copy link
Collaborator

@robinkeunen Tested (it works) and I left a suggestion above.

It does not feel write to completely take control over the code
written by many volunteers at the bees coop.
@robinkeunen robinkeunen merged commit 347ec48 into 12.0 Mar 29, 2022
@robinkeunen robinkeunen deleted the 12.0-welcome-screen branch March 29, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants