[FIX] beesdoo_shift: fix modularity #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tfrancoi
commented
Feb 24, 2022
tfrancoi
commented
- Dynamic selection should be called with a lambda
- Clear signature for _get_irregular_worker_domain
- Modular list of field to watch for tracking history
Open
- Dynamic selection should be called with a lambda
otherwise, it won't be overridable
- Clear signature for _get_irregular_worker_domain
- Modular list of field to watch for tracking history
robinkeunen
approved these changes
Feb 24, 2022
robinkeunen
force-pushed
the
12.0-beesdoo_shift-modularity
branch
from
2326ff8
to
09522f6
Compare
|
Tested on https://lenid.test.coopiteasy.be/ created a shift (create+duplicate): OK |
polchampion
reviewed
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.