Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] pos_eater #533

Open
wants to merge 46 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][MIG] pos_eater #533

wants to merge 46 commits into from

Conversation

carmenbianca
Copy link
Collaborator

Description

Migrate pos_eater. Effectively a complete rewrite.

Odoo task (if applicable)

https://gestion.coopiteasy.be/web#id=11294&action=475&active_id=492&model=project.task&view_type=form&menu_id=536

Checklist before approval

  • Tests are present (or not needed).
  • Credits/copyright have been changed correctly.
  • Change log snippet is present.
  • (If a new module) Moving this to OCA has been considered.

mclaeysb and others added 30 commits April 29, 2024 16:50
@mclaeysb @carmenbianca
Adding beesdoo_pos module (version 9.0)
569efa2 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@mclaeysb @carmenbianca
beesdoo_pos module : migration to version 10.0, 11.0 and 12.0
89173e7 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@mclaeysb @carmenbianca
[FIX] Fix version number, data tags and import ordering
3ec6c86 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@mclaeysb @carmenbianca
[FIX] remove button and functionality of print receipt
baa64a4 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
[ADD] b_pos : default customer barcode config
ffcdff3 
Override default data so as to set encoding to EAN-13.

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@houssine78 @carmenbianca
[LIC] put right licence and version
835fb92 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@houssine78 @carmenbianca
[CLEAN] remove extra tag
df50807 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@mclaeysb @carmenbianca
[REM] beesdoo_pos: remove 'Bill Value' (standard in v12) and 'Send Or…
3467163 
…ders by email' (replace with OCA module)

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@mclaeysb @carmenbianca
[FIX] beesdoo_pos: eaters on action pad and payment screen
c98f6ab 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@mclaeysb @carmenbianca
[REF] beesdoo_pos: OCA conversion renamings in screens.js
d938cc3 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@robinkeunen @carmenbianca
[REF] blacken
d1adcbf 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@robinkeunen @carmenbianca
[REF] format xml files
a10657c 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@robinkeunen @carmenbianca
[REF] add module readmes, fix manifests
2d207ca 
[REF] __manifest__: add licence, remove description

[REF] add Coop IT Easy SCRLfs to authors

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@robinkeunen @carmenbianca
[REF] pre-commit fixes
00e6851 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@vvrossem @carmenbianca
[12.0][ADD] beesdoo_pos: available_in_pos management
6a4fce6 
maintains "Available in POS" (`available_in_pos`) value
when unchecking "Can be Sold" (`sale_ok`).

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@robinkeunen @carmenbianca
[FIX] beesdoo_pos: do not assign result of include
186f385 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@houssine78 @carmenbianca
[IMP] add autoselect invoice when customer is company
1b74e2c 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@robinkeunen @carmenbianca
update precommit config
521578a 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@remytms @carmenbianca
[FIX] pre-commit: xml files
ef66e8d 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@remytms @carmenbianca
[FIX] pre-commit: python and js
8c63063 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@robinkeunen @carmenbianca
[IMP] beesdoo_pos: complete readme
877bd27 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@tfrancoi @carmenbianca
[FIX] beesdoo_pos: fix error variable name
95ffd13 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
[FIX] Run pre-commit on all files
be58bb4 
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
[FIX] Run pre-commit on all files
c715cdd 
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@victor-champonnois @carmenbianca
[FIX] use max_nb_eater defined in the share
70df878 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@victor-champonnois @carmenbianca
[IMP] allow for n eaters in pos
ff12f98 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@robinkeunen @carmenbianca
[REF] set required website to https://github.com/beescoop/Obeesdoo
611fd89 
It does not feel write to completely take control over the code
written by many volunteers at the bees coop.

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[UPD] Update beesdoo_pos.pot

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
[FIX] beesdoo_pos: Fix corner-case where get_client() returns a diffe…
3fd66cb 
…rent value between calls

Because of asynchronicity fun, get_client() would sometimes return null,
and thus raise an error.

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@victor-champonnois @carmenbianca
[REM] customer information in pos payment screen
a38cc1c 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@victor-champonnois @carmenbianca
[FIX] beesdoo_pos: Don't repeat eaters in view
da68eaa 
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
oca-ci and others added 15 commits April 29, 2024 16:58
@carmenbianca
[UPD] Update beesdoo_pos.pot
7b7fc49 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
[FIX] beesdoo_pos: Insert html instead of text
f1fba80 
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

Regenerate all README.rst

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
Bump versions
f88d4e5 
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
[FIX] SCRLfs → SC
7d54e55 
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[UPD] README.rst

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@victor-champonnois @carmenbianca
[REF] split beesdoo_base : fix dependencies
e648984 
[REF] put splitted modules as dependencies

[FIX] test-requirements

[FIX] remove beesdoo_base demo data in manifest

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@victor-champonnois @carmenbianca
[REF] split beesdoo_product
7168731 
into:
- product_main_supplier
- sale_suggested_price
- sale_adapt_price_wizard

[REF] split beesdoo_product -> product_main_supplier

[FIX] sale_suggested_price dep on product_main_supplier

[ADD] module sale_edit_price_wizard

[REF] rename sale_edit_price_wizard ->  sale_adapt_price_wizard

[REF] move rounding_method to sale_suggested_price

[REF] refactor following PR 320

[REF] search product_code -> product_main_seller

[FIX] bug adapt_sales_price

[IMP] use float_compare to compare prices

[REF] move list_price_write_date to sale_adapt_price_wizard

[FIX] beesdoo_product: main_seller_id search

[FIX] run precommit

fix

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[UPD] README.rst

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@victor-champonnois @carmenbianca
[REF] split beesdoo_pos
03572ef 
into:
- pos_eater
- pos_available_in_pos_unlink -> cie-pos
- pos_forbid_new_customer -> moved to oca/pos
- pos_partner_no_create -> moved to oca/pos

[FIX] pos_auto_invoice,pos_eater: fix js module names

[FIX] pos_auto_invoice: missing js asset

[FIX] pos_eater: fix description

[FIX] beesdoo_pos: missing dependency

[FIX] pos_eater: data in manifest

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
[UPD] Update beesdoo_pos.pot
7e2aa05 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
[UPD] Update pos_eater.pot
e232684 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[UPD] README.rst

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@github-grap-bot @carmenbianca
pos_eater 12.0.2.0.0
2705213 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@github-grap-bot @carmenbianca
beesdoo_pos 12.0.3.0.0
4f2f12b 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
[REM] beesdoo_pos
394c021 
Delete this module in advance of migrating pos_eater.

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
[MIG] pos_eater: Migration to 13.0
7fb691b 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
[MIG] pos_eater: Migration to 14.0
37f94b1 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
[MIG] pos_eater: Migration to 15.0
53e5f72 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
carmenbianca
carmenbianca commented May 2, 2024
View reviewed changes
pos_eater/static/src/xml/ActionpadWidget.xml
Comment on lines +15 to +19
<t t-if="props.partner.child_eater_ids">
<span class="eaters">
<t t-esc="eaterNames" />
</span>
</t>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is great, but if eaterNames is very long, the text disappears. See screenshot.

I do not know how to elegantly fix this.

Capture d’écran du 2024-05-02 14-47-55

Copy link
Collaborator Author

@carmenbianca carmenbianca May 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to get rid of the padding on the right. There's a decentered option for this. This doesn't solve the problem, but universally gives more space.

@carmenbianca
[MIG] pos_eater: Migration to 16.0
5f0bedc 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
polchampion
polchampion approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@polchampion polchampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successful functional test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polchampion polchampion polchampion approved these changes

@robinkeunen robinkeunen Awaiting requested review from robinkeunen

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@carmenbianca @polchampion @github-grap-bot @mclaeysb @houssine78 @robinkeunen @vvrossem @remytms @tfrancoi @victor-champonnois