Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling plugins CLI option #4325

Closed
JOJ0 opened this issue Mar 23, 2022 · 5 comments
Closed

Disabling plugins CLI option #4325

JOJ0 opened this issue Mar 23, 2022 · 5 comments
Labels
feature features we would like to implement

Comments

@JOJ0
Copy link
Member

JOJ0 commented Mar 23, 2022

The current CLI option:

-p PLUGINS, --plugins=PLUGINS
                        a comma-separated list of plugins to load

is tedious to use when many plugins are in use. Often a user might just want to disable a single plugin or a tiny list of plugins to try something/do something in a specific beets run.

Proposed solution

Add a CLI option named eg. --disable-plugins/-P that allows mentioning a comma separated list of plugin-names to stay disabled for that beets run.

@sampsyo sampsyo added the feature features we would like to implement label Mar 23, 2022
@sampsyo
Copy link
Member

sampsyo commented Mar 23, 2022

Sounds OK to me! It is probably worth noting that --plugins already can disable all plugins, so I suppose this would just be about disabling one plugin?

It could also be worth looking at the #3765 thread for inspiration about how to tackle this.

@arbanhossain
Copy link
Contributor

Hey, if I am understanding this right, I sort of have an implementation of this in my fork. It uses -x/--exclude. Should I do a PR for you to review?

@sampsyo
Copy link
Member

sampsyo commented Apr 15, 2022

A PR would be great!

@arbanhossain arbanhossain mentioned this issue Apr 15, 2022
3 tasks
@arsaboo
Copy link
Contributor

arsaboo commented May 20, 2022

Can we close this issue since #4332 is merged?

@sampsyo
Copy link
Member

sampsyo commented May 20, 2022

Yes, thanks for the reminder!!

@sampsyo sampsyo closed this as completed May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

No branches or pull requests

4 participants