Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows import library fix #79

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Windows import library fix #79

merged 5 commits into from
Sep 12, 2023

Conversation

albertopasqualetto
Copy link
Contributor

This code is tested on my Windows 11 machine.

Only libchromaprint.dll is created by chromaprint's build, and it contains all the used functions, so I removed chromaprint.dll.

Also library load doesn't work without winmode=0 for some reason.

@albertopasqualetto albertopasqualetto mentioned this pull request Aug 28, 2023
Closed
sampsyo
sampsyo reviewed Aug 29, 2023
View reviewed changes
Copy link
Member

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few questions!

chromaprint.py Outdated Show resolved Hide resolved
chromaprint.py Outdated Show resolved Hide resolved
sampsyo
sampsyo approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I found the shorter version a little easier to reason about, so I simplified that down a bit. I also verified that this works on my (macOS) system, so if this also solves your problem, I think we are good to go.

@sampsyo sampsyo merged commit ad6953d into beetbox:master Sep 12, 2023
@albertopasqualetto albertopasqualetto deleted the windows-import-fix branch September 12, 2023 15:47
@albertopasqualetto
Copy link
Contributor Author

Good!
Will you publish 1.3.0 version to pypi?

@sampsyo
Copy link
Member

sampsyo commented Sep 12, 2023

Done! https://pypi.org/project/pyacoustid/1.3.0/

@albertopasqualetto albertopasqualetto mentioned this pull request Nov 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampsyo sampsyo sampsyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertopasqualetto @sampsyo