Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code signing to the Windows MSI package command #366

Closed
freakboy3742 opened this issue Apr 19, 2020 · 6 comments
Closed

Add code signing to the Windows MSI package command #366

freakboy3742 opened this issue Apr 19, 2020 · 6 comments
Labels
enhancement New features, or improvements to existing features. windows The issue relates to Microsoft Windows support.

Comments

@freakboy3742
Copy link
Member

MSI installers can be code signed so that users don't get the "unknown publisher" warning when installing your app.

This blog post seems to cover the steps involved in signing an MSI file; it may be helpful in building a solution.

The --no-sign command line option used on the macOS package command should be mirrored here.

@freakboy3742 freakboy3742 added enhancement New features, or improvements to existing features. up-for-grabs labels Apr 19, 2020
@freakboy3742 freakboy3742 added the windows The issue relates to Microsoft Windows support. label May 10, 2020
@saroad2
Copy link
Member

saroad2 commented Jun 14, 2020

I wanted to start tackling this issue, but then I realized that in order to validate that this is working I need to get a code signing certificate, which costs money.

Do you have a certificate I can use for testing? or a dummy certificate that I could use?

@freakboy3742
Copy link
Member Author

We don't; but if you need one, I can cover the cost. Let me know what you need/where to get it, and I can sort it out for you.

That said: most certificate handling code has an option for "self signed" certificates. The cost comes when you want an external party to validate that the certificate is valid, but you can usually generate a certificate that will be valid for the purposes of "being a certificate". This is (or was, before LetsEncrypt) a common approach for testing HTTPS webservers - you can generate a self-signed certificate, but the certificate doesn't have a trust chain, which is what actually provides the security. Is there as "self signed" testing option for Windows app signing? This page would seem to suggest there might be.

@saroad2
Copy link
Member

saroad2 commented Jun 15, 2020

I never used code signing before, so I'm not familiar with the specifics of how it is done, but if you say I can use self-signed certificates, that would be more than enough by now for development. Once we finish, maybe we should consider trying out a "real" certificate on one of our BeeWare-based programs (Maybe Cricket for example).

I'll let you know how its's going :)

@ewerybody
Copy link

I just stumbled across this and was hyped until I found you also didn't solve signing yet 😄 ... Just fyi: I once dug into it a little and saw that Certum is offering a rather cheap Open-Source certificate. Everything else seems WAY to much for a hobby project.

@freakboy3742
Copy link
Member Author

@ewerybody Thanks for the link. The cost isn't a huge impediment; thanks to some very generous sponsors, we have a small income stream to offset expenses like this. That said, cheap is always nice... :-)

@freakboy3742
Copy link
Member Author

This was resolved by #890, released in Briefcase 0.3.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features, or improvements to existing features. windows The issue relates to Microsoft Windows support.
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants