Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-1212: Bundle indentifier doesnt not check reserved words #1824

Merged
merged 4 commits into from
May 22, 2024

Conversation

mas192
Copy link
Contributor

@mas192 mas192 commented May 21, 2024

Refactored config.py to accept anything but the following below

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the release note; but otherwise, this looks great! Thanks for the PR!

@freakboy3742 freakboy3742 merged commit d8059ee into beeware:main May 22, 2024
45 checks passed
@mas192
Copy link
Contributor Author

mas192 commented May 22, 2024

Thanks so much for accepting the PR 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

overly aggressive restriction on bundle identifiers restricts my idiom
2 participants