This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Fix macOS Python 3.5 & 3.7 build #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulproteus
force-pushed
the
fix-macos-builder
branch
2 times, most recently
from
aaa2f68
to
f8b183b
Compare
paulproteus
changed the title
The GitHub Actions macOS Python 3.5 and Python 3.7 distributions provide a python-config whose --ldflags doesn't print the required `-L` parameter for the compiler to find libpython. This works around that.
paulproteus
force-pushed
the
fix-macos-builder
branch
from
f8b183b
to
b25217c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub Actions macOS Python 3.5 and Python 3.7 distributions provide a python-config whose --ldflags doesn't print the required
-Lparameter for the compiler to find libpython. This works around that.It also adds printouts of
python-config --ldflagsandpython-config --cflagsin GitHub Actions for easier debugging.