Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Rename PyBee to BeeWare #8

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Conversation

paulproteus
Copy link
Contributor

@paulproteus paulproteus commented Dec 5, 2019

This is small pull request to rename PyBee to BeeWare.

I'm working on splitting out #5 into a few pull requests, mostly to improve my familiarity with this codebase.

I also removed two instances of trailing whitespace.

Testing

  • Ran Java-based test suite.
➜  rubicon-java git:(pybee-beeware) java org.beeware.rubicon.test.Test
Start Python runtime...
Initializing Python runtime...
Import rubicon...
test_float_method (tests.test_jni.JNITest) ... ok
test_non_existent (tests.test_jni.JNITest) ... ok
test_object_lifecycle (tests.test_jni.JNITest) ... ok
test_static (tests.test_jni.JNITest) ... ok
test_string (tests.test_jni.JNITest) ... ok
test_string_method (tests.test_jni.JNITest) ... ok
test_alternatives (tests.test_rubicon.JNITest) ... ok
test_double_method (tests.test_rubicon.JNITest) ... ok
test_enum_method (tests.test_rubicon.JNITest) ... ok
test_field (tests.test_rubicon.JNITest) ... ok
test_float_method (tests.test_rubicon.JNITest) ... ok
test_inner (tests.test_rubicon.JNITest) ... ok
test_interface (tests.test_rubicon.JNITest) ... ok
test_method (tests.test_rubicon.JNITest) ... ok
test_non_existent_field (tests.test_rubicon.JNITest) ... ok
test_non_existent_method (tests.test_rubicon.JNITest) ... ok
test_non_existent_static_field (tests.test_rubicon.JNITest) ... ok
test_non_existent_static_method (tests.test_rubicon.JNITest) ... ok
test_non_static_access_static (tests.test_rubicon.JNITest) ... ok
test_object_return (tests.test_rubicon.JNITest) ... ok
test_polymorphic_constructor (tests.test_rubicon.JNITest) ... ok
test_polymorphic_method (tests.test_rubicon.JNITest) ... ok
test_polymorphic_static_method (tests.test_rubicon.JNITest) ... ok
test_protected_field (tests.test_rubicon.JNITest) ... ok
test_protected_method (tests.test_rubicon.JNITest) ... ok
test_protected_static_field (tests.test_rubicon.JNITest) ... ok
test_protected_static_method (tests.test_rubicon.JNITest) ... ok
test_simple_object (tests.test_rubicon.JNITest) ... ok
test_static_access_non_static (tests.test_rubicon.JNITest) ... ok
test_static_field (tests.test_rubicon.JNITest) ... ok
test_static_method (tests.test_rubicon.JNITest) ... ok
test_string_argument (tests.test_rubicon.JNITest) ... ok
test_string_return (tests.test_rubicon.JNITest) ... ok

----------------------------------------------------------------------
Ran 33 tests in 0.036s

OK
  • Ran manual test to ensure Python starts (or at least, we get a 0 return code when trying to start Python)
➜  rubicon-java git:(pybee-beeware) jshell --class-path /home/paulproteus/projects/beeware/rubicon-java/dist/rubicon.jar
|  Welcome to JShell -- Version 11.0.4
|  For an introduction type: /help intro

jshell> import org.beeware.rubicon.Python;

jshell> org.beeware.rubicon.Python.start(null, "/home/paulproteus/projects/beeware/rubicon-java/", "/home/paulproteus/projects/beeware/rubicon-java/dist/librubicon.so")
$2 ==> 0

jshell>

@paulproteus
Copy link
Contributor Author

@freakboy3742 I'll be online for the next ~30 min; if you review this after 30 min from now, that's totally fine, but it'll probably be Pacific-time morning before I have a chance to respond.

Cheers!

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a big change, but looks fairly straightforward.

Taking you on your word that you've run CI. Ideally, that's something we'll address fairly soon :-)

@freakboy3742 freakboy3742 merged commit 335addf into beeware:master Dec 5, 2019
@paulproteus paulproteus deleted the pybee-beeware branch December 5, 2019 03:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants