Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toga Label not working on iOS #75

Merged
merged 1 commit into from
Oct 26, 2016
Merged

Conversation

marcmolla
Copy link
Contributor

If you add a Label in iOS, the application crash with the exception:

  File "/Users/marc/Library/Developer/CoreSimulator/Devices/294E285B-2221-460A-B009-B2FFF9DB83D4/data/Containers/Bundle/Application/B2E6BC5C-4ECC-447D-810D-ACD19EFFE87D/Hello World.app/Library/Python.framework/Resources/lib/python3.5/site-packages/colosseum/layout.py", line 174, in _set_dimension_from_style
    if not self._dimension_is_defined(axis):
  File "/Users/marc/Library/Developer/CoreSimulator/Devices/294E285B-2221-460A-B009-B2FFF9DB83D4/data/Containers/Bundle/Application/B2E6BC5C-4ECC-447D-810D-ACD19EFFE87D/Hello World.app/Library/Python.framework/Resources/lib/python3.5/site-packages/colosseum/layout.py", line 110, in _dimension_is_defined
    return value is not None and value > 0
TypeError: unorderable types: tuple() > int()

The error seems to be in this line, but I am not sure if I understood correctly all the layout stuff :) I just compared this line in other widgets and cocoa implementation... and at the end, the app works with this patch.

@marcmolla marcmolla mentioned this pull request Oct 26, 2016
@freakboy3742 freakboy3742 merged commit db343c9 into beeware:master Oct 26, 2016
@freakboy3742
Copy link
Member

Your instincts are correct; it looks like a piece of code that was left over from an older iteration of the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants