Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php8.1 #188

Merged
merged 5 commits into from
Feb 6, 2023
Merged

Add php8.1 #188

merged 5 commits into from
Feb 6, 2023

Conversation

valdislav
Copy link
Contributor

No description provided.

Copy link
Collaborator

@ko-be ko-be left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Overall it looks great but have a few requested changes.

Dockerfile-8.1 Outdated Show resolved Hide resolved
Dockerfile-8.1 Outdated Show resolved Hide resolved
Dockerfile-8.1 Outdated Show resolved Hide resolved
@valdislav valdislav requested a review from ko-be December 15, 2022 23:01
@ko-be
Copy link
Collaborator

ko-be commented Dec 15, 2022

@valdislav can you please also add a section similar to this for 8.1:

https://github.com/behance/docker-php/blob/master/.github/workflows/publish.yml#L24-L26

@valdislav
Copy link
Contributor Author

Waiting for #189 to be merged.

@ko-be
Copy link
Collaborator

ko-be commented Jan 5, 2023

@valdislav #189 has been merged, can you please rebase?

@valdislav
Copy link
Contributor Author

@ko-be Done

@ko-be ko-be merged commit 1ff206d into behance:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants