Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unchecked return values from get_nominal_glyph() #411

Closed
pwithnall opened this issue Feb 1, 2017 · 1 comment
Closed

Unchecked return values from get_nominal_glyph() #411

pwithnall opened this issue Feb 1, 2017 · 1 comment

Comments

@pwithnall
Copy link
Contributor

I’ve been running Coverity on Harfbuzz, and it’s flagged up a couple of places where the return value of get_nominal_glyph() is not checked, even though it’s checked everywhere else. I don’t know enough about the handling of codepoint 0 to know whether this is OK:

  • _hb_fallback_shape() in hb-fallback-shape.cc (Coverity ID: 141031)
  • set_glyph() in hb-ot-shape-normalize.cc (Coverity ID: 124694)

If it’s OK to ignore the return values here, I can mark the Coverity reports as to be ignored. Otherwise, I guess some code changes are needed to propagate the error handling.

@behdad behdad closed this as completed in 1dd630a Feb 1, 2017
@behdad
Copy link
Member

behdad commented Feb 1, 2017

Thanks. Those are intentional. Added casts that should silence these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants