You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I’ve been running Coverity on Harfbuzz, and it’s flagged up a couple of places where the return value of get_nominal_glyph() is not checked, even though it’s checked everywhere else. I don’t know enough about the handling of codepoint 0 to know whether this is OK:
_hb_fallback_shape() in hb-fallback-shape.cc (Coverity ID: 141031)
set_glyph() in hb-ot-shape-normalize.cc (Coverity ID: 124694)
If it’s OK to ignore the return values here, I can mark the Coverity reports as to be ignored. Otherwise, I guess some code changes are needed to propagate the error handling.
The text was updated successfully, but these errors were encountered:
I’ve been running Coverity on Harfbuzz, and it’s flagged up a couple of places where the return value of
get_nominal_glyph()
is not checked, even though it’s checked everywhere else. I don’t know enough about the handling of codepoint 0 to know whether this is OK:_hb_fallback_shape()
inhb-fallback-shape.cc
(Coverity ID: 141031)set_glyph()
inhb-ot-shape-normalize.cc
(Coverity ID: 124694)If it’s OK to ignore the return values here, I can mark the Coverity reports as to be ignored. Otherwise, I guess some code changes are needed to propagate the error handling.
The text was updated successfully, but these errors were encountered: