hb-private.hh needs to #include Windows.h under MSVC #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to ensure DEFINE_ENUM_FLAG_OPERATORS works as expected. See https://bugzilla.mozilla.org/show_bug.cgi?id=1226175#c10.
|
I'm just pushing out a change, changing that piece of code. |
gpgreen
pushed a commit
to gpgreen/harfbuzz
that referenced
this pull request
Jan 10, 2024
Add -mbig-obj flag when building harfbuzz on windows-gnu When building on window-gnu targets I was getting "file too big errors" in harfbuzz-sys. This adds the assembler flag -mbig-obj on windows-gnu targets which fixes the error, based on the advice [here](https://digitalkarabela.com/mingw-w64-how-to-fix-file-too-big-too-many-sections/). I have tested this with both the x86_64-pc-windows-gnu and i686-pc-windows-gnu targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to ensure DEFINE_ENUM_FLAG_OPERATORS works as expected. See https://bugzilla.mozilla.org/show_bug.cgi?id=1226175#c10.