-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test fixes: fix record-test.sh for current fonttools, doc update #445
Conversation
They worked for me rather recently, what part did not work with Python 3, we should probably just fix it. |
Running the existing tests does work without any changes, however the test-recording tools do not.
It would be some work to fix this for both python2 and 3 due to differences in unicode handling between the two versions. |
We are almost Python 3 compatible, let me fix the small remaining bit. |
The Python 3 part should be fixed now. |
Merge branch 'master' into test-fixes
Hi, your changes work fine, and this is a much better solution, so I've undone the insertion of the shebangs. Is that the right approach, or should I generate a new pull request? |
You can use interactive rebase |
Git took already care of it. The patch doesn't affect the python-files anymore. Tx! |
But there are still 5 commit when there should only be 2. Fixed it and pushed manually. |
This introduces changes to the test-tools and a documentation update:
(Former change of shebangs is reverted, see discussion below)