You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm creating a wrapper plugin for integrating Csharpier with dprint, but I've hit a snag as the Csharpier.Core package only exposes CodeFormatterOptions, which currently only contains the setting for PrintWidth.
Would it be possible to get all the options exposed? I'm willing to create a PR to add this, although I'd prefer knowing the reasoning for the current split of CodeFormatterOptions and PrinterOptions first.
The text was updated successfully, but these errors were encountered:
If I recall correctly, I added CodeFormatterOptions when there was just the single option for width, and then missed adding tabs/indent size. PrinterOptions contains a lot of options that didn't make sense to expose in CSharpier.Core which I believe is why I split them originally.
I'm not in love the the names in PrinterOptions - I'm thinking that TabWidth changes to IndentSize on CodeFormatterOptions (to line up with the editorconfig name). And maybe UseTabs should be an enum called IndentStyle, but an enum for just two options could be overkill.
I have no problem exposing the options so go ahead with the PR.
Phault
added a commit
to Phault/csharpier
that referenced
this issue
Feb 12, 2024
I'm creating a wrapper plugin for integrating Csharpier with dprint, but I've hit a snag as the Csharpier.Core package only exposes CodeFormatterOptions, which currently only contains the setting for PrintWidth.
Would it be possible to get all the options exposed? I'm willing to create a PR to add this, although I'd prefer knowing the reasoning for the current split of CodeFormatterOptions and PrinterOptions first.
The text was updated successfully, but these errors were encountered: