Line endings not set

[phuhl]

It seems that running dotnet-csharpier . on our project folder does not do anything about line endings. Files that have "lf" line endings keep them, files that have "crlf" keep them, too.

I'd expect that one of the two is chosen and applied.

Am I doing something wrong?

[phuhl]

Ok, it seems that csharpier by default uses the EndOfLine.Auto mode. Changing the first line in a file from LF to CRLF makes csharpier reformat the whole file and vice versa.

I'd argue, csharpier should behave differently and pick one line ending as otherwise you still have different OSes with different line endings that might interfere and constantly change line endings from the one to the other.

[belav]

The current behavior is taken from prettier. Originally CSharpier exposed options for Auto, CRLF and LF, but that was removed early on. If CSharpier were to use only LF, I assume that would make some windows users unhappy, and vice versa.

Another option would be to read the first file to determine which line ending to use, but if that first file changes, or if the first file is not always consistent then things could also flip back and forth.

The advice we've followed at work is to get all of the line endings consistent, and then use a .gitattributes file with * text=auto, which checks out the file with CRLF on windows, but commits it as LF. And non-windows leaves it as LF.

I'm not opposed to re-exposing the options for line endings, which would solve your problem and also allow people to easily do a one time cleanup before changing it back to auto.

[phuhl]

Ah, interesting, I did not know about the situation at prettierjs. Apparently, the current solution prettierjs uses is by default to enforce LF but a config option exists that can be set to auto, cr, lf, or crlf (https://prettier.io/docs/en/options.html#end-of-line).

For our team, re-exposing the existing option would solve our issue :)