Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider wide unicode characters to be size of 2 #1237

Merged
merged 2 commits into from
May 3, 2024
Merged

Consider wide unicode characters to be size of 2 #1237

merged 2 commits into from
May 3, 2024

Conversation

belav
Copy link
Owner

@belav belav commented Apr 20, 2024

closes #260

shocklateboy92
shocklateboy92 approved these changes Apr 20, 2024
View reviewed changes
Copy link
Collaborator

@shocklateboy92 shocklateboy92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, that was not a problem I ever expected to encounter

@belav
Copy link
Owner Author

belav commented May 1, 2024

Damn, that was not a problem I ever expected to encounter

Didn't actually encounter it, but prettier had code for handling it when I ported things over and I finally got around to implementing it.

@belav belav merged commit ed295a5 into main May 3, 2024
3 checks passed
@belav belav deleted the unicode-width branch May 3, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shocklateboy92 shocklateboy92 shocklateboy92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fullwidth unicode characters should be accounted for in print width
2 participants
@belav @shocklateboy92