Fix issue with csharpier server not using dotnet root #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shocklateboy92
approved these changes
Apr 23, 2024
| this.formatFile("public class ClassName { }", "/Temp/Test.cs").then(() => { | ||
| this.formatFile("public class ClassName { }", "/Temp/Test.cs"); | ||
| // make sure we give a path that should not exist to avoid any errors when trying to find config files etc. | ||
| this.formatFile("public class ClassName { }", `/${Date.now()}/Test.cs`).then(() => { |
There was a problem hiding this comment.
if the goal is for the directory to not exists, why not just use ""?
There was a problem hiding this comment.
If I remember correctly, csharpier is unhappy if you do that. There should probably just be an option for "no file path" and 0.28.0 would have been the time to add it. Dammit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1238