Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equivalences are being droppped #101

Closed
wshayes opened this issue Aug 20, 2018 · 0 comments
Closed

Equivalences are being droppped #101

wshayes opened this issue Aug 20, 2018 · 0 comments
Assignees
@wshayes

Comments

@wshayes
Copy link
Contributor

wshayes commented Aug 20, 2018 •
edited
Loading

get_equivalents() in services/terms.py is dropping equivalences. It should change:

equivalents[record['namespace']] = record['term_id']

to append to the list

equivalents[record['namespace']].append( record['term_id'])

Then update everywhere that's using this call to use the list of equivalences.

child of #99 (should be done at same time)
@wshayes wshayes self-assigned this Aug 20, 2018
wshayes added a commit that referenced this issue Sep 4, 2018
@wshayes
Fixes #96, #101, #99 and belbio/bel_sources#96
86099d9 
Fixed issue with equivalencing - both the issue of slow equivalencing due to using up to 10 steps for equivalences and the issue that alt_ids were not included in equivalencing.

Also fixed the issue with dashes and underscores being used to tokenize text for term completion - now we only use colons and spaces for tokenization.

Also shifted api routes into a separate file.
@wshayes wshayes closed this as completed Sep 12, 2018
wshayes added a commit to belbio/bel that referenced this issue Oct 22, 2018
@wshayes
Equivalencing - fixes #belbio/bel_api#101 belbio/bel_resources#96 bel…
20e3859 
…bio/bel_api#99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wshayes wshayes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wshayes