Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Union Type is added in Python 3.10 #32

Closed
andy-seleya opened this issue Jun 27, 2024 · 3 comments · Fixed by #35
Closed

Union Type is added in Python 3.10 #32

andy-seleya opened this issue Jun 27, 2024 · 3 comments · Fixed by #35
Labels
bug Something isn't working

Comments

@andy-seleya
Copy link

Considering union type is available starting from python 3.10 (docs), adding location based search #28 will limit python version to 3.10+.

image
@GalenReich GalenReich added the bug Something isn't working label Jun 27, 2024
@GalenReich
Copy link
Collaborator

Am I right in thinking that this tweak to use the existing typing.Union import would fix this?

def parse_location_input(location_input: Union[str, tuple, None]) -> Union[str, None]:

@GalenReich
Copy link
Collaborator

Or we could add:

from __future__ import annotations

@andy-seleya
Copy link
Author

agree, they should work

jordan-gillard added a commit to jordan-gillard/EDGAR that referenced this issue Jul 7, 2024
@jordan-gillard
Add tox workflow, single test, and fix union usage
04d5c04 
Resolves: bellingcat#32
@jordan-gillard jordan-gillard mentioned this issue Jul 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix union use in utils.py & add tox GitHub workflow jordan-gillard/EDGAR
2 participants
@GalenReich @andy-seleya