-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea: Replace Leaflet map with Mapbox #43
Comments
(This might be an interesting discussion for the upstream repository as well.) This is a neat demo, thank you for putting it together and sharing it! MapboxGL does appear to render smoother, especially when zooming. Some questions:
There are a few decisions I really like in your implementation that we should consider for this project in any case:
|
Aha, I hadn't realized that after setting the filters one can see the pie charts before you mentioned it. It's a bit of a hidden feature :) Rendering pie charts isn't straightforward with Mapbox, but it's possible to do it in an SVG overlay.
Yes, there's MapLibre GL JS which is behind the latest Mapbox developments but should also work in principle. But can you elaborate on why is the licensing problematic?
I also set the opacity of the satellite raster layer to |
It's admittedly more of an issue for the upstream project that this timemap is forked from as we already use mapbox tiles here. The new license forces users to have a mapbox account and thereby adhere to their ToS before the library can be used to embed a map. This locks the OSS project pretty firmly to mapbox and might prevent some people from using it in the future if they cannot comply with the tos for w/e reason. |
Okay, I will try then to see how it works with MapLibre |
I tried. It works with MapLibre too: The only issue is that it doesn't seem to support the new mapbox styles, so I had to resort to MapTiler. Satellite resolution there is not as good as with MapBox even for Kiev: |
These are not pressing changes and we'd like to keep leaflet for now, not sure if @breezykermo sees it as a good addition to the upstream though. |
Another idea:
I tried to throw the data onto a Mapbox map and enabled clustering. The interaction feels smoother: https://ukraine-civilian-harm.vercel.app/
What do you think? Would you consider replacing the Leaflet map in the app?
The text was updated successfully, but these errors were encountered: