-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge perfaram/master into beltex/swift2 #21
Conversation
…ing, tuples for output dictionary (Any?, String)
New CallSMC function (taking a selector in)
Hi @perfaram! Thanks for the pull request, its much appreciated, and the first of the project too! :) This is neat work, but I wanted to take a bit of a different approach. While the underlying mechanism would be using the index selector, wanted to stick to primarily temperature keys only for now. So something like Thus, I will not be merging this. However, I’ll note some feedback nonetheless for future reference. |
@@ -617,6 +662,8 @@ public struct SMC { | |||
- parameter key: The SMC key to check. 4 byte multi-character constant. Must be | |||
4 characters in length. | |||
- returns: valid True if the key is found, false otherwise | |||
- returns: IOReturn IOKit return code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these got added back in. I removed them because originally, way back, I had thought there should be a :returns:
line for each return value, since tuple returns were new to Swift. However, single return line is the convention it seems, independent of the number of values.
So, thanks for having looked over the modifications even if you didn't mean to merge. Thus, thanks also for the tips. |
Fixes #17 and follows #20