Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: valid JSDoc #8

Merged
merged 2 commits into from
Feb 17, 2017
Merged

fix: valid JSDoc #8

merged 2 commits into from
Feb 17, 2017

Conversation

birhoff
Copy link
Contributor

@birhoff birhoff commented Feb 17, 2017 •
edited
Loading

Resolve #4

tadatuta
tadatuta reviewed Feb 17, 2017
View reviewed changes
.editorconfig Outdated
[*.{bemjson.js,deps.js}]
indent_size = 4

[{data-stub/**.json,*.json}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need in data-stub part

common.blocks/calendar/calendar.js Outdated
@@ -137,13 +136,11 @@ provide(bemDom.declBlock(this.name, /** @lends calendar.prototype */{
/**
* Parse date
*
* param {Date|string} val
* @returns {?Date} this
* @param {Date|String} val - Date or Date like string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like -> as?

@birhoff
Copy link
Contributor Author

birhoff commented Feb 17, 2017

/up

@tadatuta tadatuta merged commit 5a66fc6 into master Feb 17, 2017
@tadatuta tadatuta deleted the fix/valid_jsdoc branch February 17, 2017 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadatuta tadatuta tadatuta left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birhoff @tadatuta