Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkbox, checkbox-group: improve JAWS readability #1558

Merged
merged 2 commits into from
Aug 10, 2015
Merged

checkbox, checkbox-group: improve JAWS readability #1558

merged 2 commits into from
Aug 10, 2015

Conversation

sipayRT
Copy link
Contributor

@sipayRT sipayRT commented Jun 26, 2015

Closes #1492 #1521

@sipayRT sipayRT added the ready label Jun 26, 2015
@tadatuta tadatuta mentioned this pull request Jun 26, 2015
Closed
20 tasks
@sipayRT sipayRT force-pushed the issues/1492@v2 branch 2 times, most recently from e0973d4 to cff877e Compare July 30, 2015 13:14
@sipayRT
Copy link
Contributor Author

sipayRT commented Jul 30, 2015

@aristov this branch was rebased. After button's review this code was totally remade in more easier way. Need your review

@aristov
Copy link
Contributor

aristov commented Aug 3, 2015

JAWS reads text field of checkbox (without _type_button) twice when arrow-key navigation is used. Try to use span with role="presentation" or aria-hidden="true" to wrap text and hide it from JAWS.

@sipayRT
Copy link
Contributor Author

sipayRT commented Aug 6, 2015

@aristov

JAWS reads text field of checkbox (without _type_button) twice

I thought that it's norman behavior. Added elem __text with 'aria-hidden' attribute. Plz, check it

@aristov
Copy link
Contributor

aristov commented Aug 10, 2015

LGTM

sipayRT added a commit that referenced this pull request Aug 10, 2015
@sipayRT
Merge pull request #1558 from /issues/1492@v2
cf5ec16 
checkbox, checkbox-group: improve JAWS readability
@sipayRT sipayRT merged commit cf5ec16 into issues/1206-common@v2 Aug 10, 2015
@sipayRT sipayRT removed the ready label Aug 10, 2015
@sipayRT sipayRT deleted the issues/1492@v2 branch August 10, 2015 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sipayRT @aristov