progressbar: improve JAWS readability #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| attrs : { style : 'width:' + (this.ctx.val || 0) + '%' } | ||
| attrs : { | ||
| style : 'width:' + val, | ||
| role : 'progressbar', |
There was a problem hiding this comment.
role and aria-valuenow attributes should be added to the root node of the block.
There was a problem hiding this comment.
For this we should change style and aria-valuenow attributes in different places. It will be strange.
For example:
<div class="progressbar" aria-valuenow="20">
<div class="progressbar__bar" style="width:20%"></div>
</div>
Two DOM-nodes will be changed each second while some process will be going. If this is not so terrible, I can move these attributes
There was a problem hiding this comment.
I think it's not so terrible. Let's do it.
sipayRT
force-pushed
the
issues/1511@v2
branch
2 times, most recently
from
7b0e039
to
adfb300
Compare
|
@aristov all a11y attributes was moved to the root node |
| @@ -1,14 +1,27 @@ | |||
| block('progressbar')( | |||
| def()(function() { | |||
| var val = this.ctx.val || 0; | |||
There was a problem hiding this comment.
No need to create variable here.
|
@aristov updated |
| .content({ | ||
| elem : 'bar', | ||
| attrs : { style : 'width:' + val + '%' } | ||
| attrs : { | ||
| style : 'width:' + val + '%' |
|
@aristov updated |
|
LGTM, wait for Gemini tests passing and merge. |
sipayRT
added a commit
that referenced
this pull request
Jul 28, 2015
progressbar: improve JAWS readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1511