Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i-bem.bemhtml: Do not repeat block class on mix with same block's mod #804

Closed
tadatuta opened this issue Jan 18, 2015 · 0 comments
Closed

i-bem.bemhtml: Do not repeat block class on mix with same block's mod #804

tadatuta opened this issue Jan 18, 2015 · 0 comments
Labels
bug v2 v4

Comments

@tadatuta
Copy link
Member 

{
    block: 'b1',
    mix: { block: 'b1', mods: { m1: 'v1' } }
}

results with

<div class="b1 b1 b1_m1_v1"></div>

It's inconsistent with BH and creates issues with tmpl-specs.
@tadatuta tadatuta mentioned this issue Jan 18, 2015
Merged
tadatuta added a commit that referenced this issue Jan 29, 2015
@tadatuta
Merge pull request #805 from /issues/804@v2
f5a1d3c 
i-bem.bemhtml: Do not repeat block class on mix with same block's mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug v2 v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@veged @tadatuta