Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm-shrinkwrap.json to lock npm dependencies #1065

Closed
wants to merge 1 commit into from

Conversation

narqo
Copy link
Member

@narqo narqo commented Jun 18, 2015

npm-shrinkwrap should prevent accident breaks after npm dependencies update (current xjst version, for example)

/jfi @tadatuta

@narqo
Copy link
Member Author

narqo commented Jun 18, 2015

Everything works with xjst@1.5.0 locked

@tadatuta
Copy link
Member

Not sure about it.

  1. We agreed with @indutny to use strong deps in bem-xjst on xjst
  2. It's better to find regression in our libs before our users
  3. Shrinkwrap won't help our users anyway but will make us to regenerate it each time we need to update any npm dependency.

@narqo
Copy link
Member Author

narqo commented Jun 18, 2015

But at the same time, I don't understand, how this strict dependency helps us?

  1. We are not depend from bem-xjst in bem-components, and currently we depend from bem-xjst@0.9 and enb-bemxjst@1.3.4 in bem-core. What (and by who) should be done, so our PRs in bem-core start working?
  2. If all dependencies in bem-xjst and other bem-enb-blahblah libraries will be strict what should be done (and by who) to test that the new version of xjst doesn't break bem-core?

Can't we use project-stub with semver dependencies or any other repo for such smoke testing?

@tadatuta
Copy link
Member

  1. We have dependency on bem-xjst which had soft dependency on xjst. As it was replaced with strong dependency there's no change to get such breaking update any more (after update on new version of bem-xjst in bem-core).
  2. Actually there are tests in bem-xjst and when broken xjst was released they failed. But that hadn't prevented us from getting that xjst version with soft deps. Then we have tests in enb-bemxjst. So with strong deps we will get an update just after all of them will pass.

@narqo
Copy link
Member Author

narqo commented Jun 18, 2015

I still don't understand how does it all match to the phrase

It's better to find regression in our libs before our users

How could such regressions been found with bem-core if all our dependencies are strict?

@narqo
Copy link
Member Author

narqo commented Jun 18, 2015

In any case I don't care much, my PR has been build finally with xjst@1.5.3 :)

@narqo narqo closed this Jun 18, 2015
@narqo narqo deleted the add-npm-shrinkwrap@v3 branch June 18, 2015 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants