Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#329 Use bemhtml from bem-xjst #330

Merged
merged 1 commit into from
Dec 25, 2013
Merged

#329 Use bemhtml from bem-xjst #330

merged 1 commit into from
Dec 25, 2013

Conversation

tadatuta
Copy link
Member

@tadatuta tadatuta commented Dec 9, 2013

// cc @indutny @veged Посмотрите, пожалуйста, если все ок, сделаю аналогично в остальных библиотеках

@indutny
Copy link
Contributor

indutny commented Dec 10, 2013

Похоже, что все правильно.

@tadatuta
Copy link
Member Author

@indutny Федя, точно ли часть про оборачивание результатов компиляции (https://github.com/bem/bem-core/blob/feature/329%40v1/.bem/techs/bemhtml.js#L58-L75) должна находиться в технологии сборки?

@veged
Copy link
Member

veged commented Dec 11, 2013

@indutny @tadatuta кажется, что оборачивание не привязано никак к bem-core (да и к BEM вообще) — можно было бы её унести в XJST (или в bem-xjst)

@narqo
Copy link
Member

narqo commented Dec 11, 2013

@veged @indutny @tadatuta нужно только не забыть, что в экспорте, для bemhtml, нужна переменная BEMHTML, а для bemtree — BEMTREE :)

@veged
Copy link
Member

veged commented Dec 11, 2013

@narqo это может быть примерно также параметром

@tadatuta
Copy link
Member Author

Завел bem/bem-xjst#7

narqo pushed a commit that referenced this pull request Dec 25, 2013
@narqo narqo merged commit c95a3b3 into v1 Dec 25, 2013
@narqo narqo deleted the feature/329@v1 branch December 25, 2013 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants