Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i-bem-js.ru.md: Update for v2 Close #395 #696

Merged
merged 1 commit into from
Oct 27, 2014
Merged

i-bem-js.ru.md: Update for v2 Close #395 #696

merged 1 commit into from
Oct 27, 2014

Conversation

Murdalay
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 0711f2f on issues/#395@v2 into a5efc85 on v2.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 0297a2c on issues/#395@v2 into a5efc85 on v2.

@@ -1021,6 +1104,63 @@ DOM.decl('my-form', {
в процессе работы блока, следует использовать метод экземпляра блока
`un(event, [handler], [handlerCtx])`.

### События при изменении модификаторов
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the whole part looks like a lot of copy-paste.
let's use wrapping snippet just once with all the variants and add inline comments for each line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not update this part yet. Working with it right now.

onSetMod: {
'js': {
'inited': function() {
block1.on({ modName : 'm1', modVal : '*' }, function() {})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

потерялся отступ и точка с запятой

@coveralls
Copy link

Coverage Status

Coverage increased (+0.12%) when pulling 3c2b9d1 on issues/#395@v2 into a5efc85 on v2.

@tadatuta
Copy link
Member

@Murdalay please squash the commits and rebase on v2

@Murdalay
Copy link
Contributor Author

Done. Check if it's right, please.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling fc638fd on issues/#395@v2 into efab69f on v2.

tadatuta added a commit that referenced this pull request Oct 27, 2014
i-bem-js.ru.md: Update for v2 Close #395
@tadatuta tadatuta merged commit 1b8b2f3 into v2 Oct 27, 2014
@tadatuta tadatuta deleted the issues/#395@v2 branch October 27, 2014 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants