Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearfix block Russian description Close #771 #775

Merged
merged 1 commit into from
Jan 23, 2015
Merged

Conversation

Murdalay
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a8353e6 on issues/#771@v2 into 1cdfb57 on v2.

@@ -0,0 +1,59 @@
# clearfix

Блок реализует популярный CSS-прием **clearfix**, также известный как [Easy Clearing Hack](http://www.456bereastreet.com/archive/200603/new_clearing_method_needed_for_ie7/). Прием позволяет отменить обтекание, для блочных элементов `<div>` с CSS-свойством `float`, без внесения изменений в исходную HTML-структуру документа.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

кусок «для блочных элементов <div>» следует удалить

@Murdalay
Copy link
Contributor Author

Check if it's ok.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling d9ca2be on issues/#771@v2 into c9d219e on v2.

@tadatuta
Copy link
Member

foat так и остался foat

@Murdalay
Copy link
Contributor Author

Done. Squashed and rebased.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c55743d on issues/#771@v2 into c9d219e on v2.

},
{
block: 'clearfix',
attrs: { style: '' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я имел в виду, чтобы тут были заинлайнены правильные стили для демонстрации поведения

@Murdalay
Copy link
Contributor Author

I've added the inline styles. Check if it's ok.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.12%) when pulling 46e9371 on issues/#771@v2 into c9d219e on v2.

{
block: 'some-container',
mix: [{ block: 'clearfix' }],
attrs: { style: '' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

думаю и здесь и в предыдущем примере есть смысл задать блоку-обертке и блокам float разноцветные бордеры, чтобы было видно как код работает в результате

@Murdalay
Copy link
Contributor Author

Check this out)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.12%) to 83.21% when pulling 0dc370b on issues/#771@v2 into c9d219e on v2.

},
{
block: 'clearfix',
attrs: { style: 'border: 2px dotted yello' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yello -> yellow

@Murdalay
Copy link
Contributor Author

Fixed. Something else?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.12%) to 83.21% when pulling 0cfea09 on issues/#771@v2 into c9d219e on v2.

content: [
{
block: 'float',
attrs: { style: { 'float: left', 'border: 1px solid green' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attrs: { style: { 'float: left', 'border: 1px solid green' }} -> attrs: { style: 'float: left'; border: 1px solid green;' }
and same for other situations.

you may test examples with the help of project-stub ;)

@Murdalay
Copy link
Contributor Author

I've tested both examples.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.12%) to 83.21% when pulling 44780a5 on issues/#771@v2 into c9d219e on v2.

},
{
block: 'footer',
attrs: { style: 'border: 2px solid red; width: 20%' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why width: 20% here and in the next example?
looks like it's the final thing. please remove it and squash commits

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's because if it will be 100% it does not fit to clerfix block anyway. So I made it 20% for convenience.
On the other hand, it will noticeably collapse, so I could remove it if you like.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I not got it. Still think it's better to remove.

@Murdalay
Copy link
Contributor Author

Done and squashed.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.21% when pulling 60fc369 on issues/#771@v2 into c58678c on v2.

tadatuta added a commit that referenced this pull request Jan 23, 2015
clearfix block Russian description Close #771
@tadatuta tadatuta merged commit 184f68a into v2 Jan 23, 2015
@tadatuta tadatuta deleted the issues/#771@v2 branch January 23, 2015 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants