-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clearfix block Russian description Close #771 #775
Conversation
@@ -0,0 +1,59 @@ | |||
# clearfix | |||
|
|||
Блок реализует популярный CSS-прием **clearfix**, также известный как [Easy Clearing Hack](http://www.456bereastreet.com/archive/200603/new_clearing_method_needed_for_ie7/). Прием позволяет отменить обтекание, для блочных элементов `<div>` с CSS-свойством `float`, без внесения изменений в исходную HTML-структуру документа. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
кусок «для блочных элементов <div>
» следует удалить
a8353e6
to
d9ca2be
Compare
Check if it's ok. |
|
d9ca2be
to
c55743d
Compare
Done. Squashed and rebased. |
}, | ||
{ | ||
block: 'clearfix', | ||
attrs: { style: '' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
я имел в виду, чтобы тут были заинлайнены правильные стили для демонстрации поведения
I've added the inline styles. Check if it's ok. |
{ | ||
block: 'some-container', | ||
mix: [{ block: 'clearfix' }], | ||
attrs: { style: '' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
думаю и здесь и в предыдущем примере есть смысл задать блоку-обертке и блокам float
разноцветные бордеры, чтобы было видно как код работает в результате
Check this out) |
}, | ||
{ | ||
block: 'clearfix', | ||
attrs: { style: 'border: 2px dotted yello' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yello -> yellow
Fixed. Something else? |
content: [ | ||
{ | ||
block: 'float', | ||
attrs: { style: { 'float: left', 'border: 1px solid green' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
attrs: { style: { 'float: left', 'border: 1px solid green' }}
-> attrs: { style: 'float: left'; border: 1px solid green;' }
and same for other situations.
you may test examples with the help of project-stub
;)
I've tested both examples. |
}, | ||
{ | ||
block: 'footer', | ||
attrs: { style: 'border: 2px solid red; width: 20%' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why width: 20%
here and in the next example?
looks like it's the final thing. please remove it and squash commits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's because if it will be 100% it does not fit to clerfix block anyway. So I made it 20% for convenience.
On the other hand, it will noticeably collapse, so I could remove it if you like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I not got it. Still think it's better to remove.
44780a5
to
60fc369
Compare
Done and squashed. |
clearfix block Russian description Close #771
No description provided.