Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ua block Russian description Close #779 #786

Merged
merged 1 commit into from
Feb 12, 2015
Merged

ua block Russian description Close #779 #786

merged 1 commit into from
Feb 12, 2015

Conversation

Murdalay
Copy link
Contributor

@Murdalay Murdalay commented Jan 5, 2015

Description include blocks from common and desktop levels.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9c30cda on issues/#779@v2 into 9436ea6 on v2.

['i-bem__dom', 'ua'],
function(provide, BEMDOM, ua) {

provide(BEMDOM.decl({ block : this.name }, /** @lends uatest.prototype */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{ block : this.name } -> this.name

@tadatuta
Copy link
Member

tadatuta commented Jan 5, 2015

не хватает описания с тачевого уровня

@Murdalay Murdalay force-pushed the issues/#779@v2 branch 2 times, most recently from 48188c3 to 004f2e1 Compare February 12, 2015 14:35
@Murdalay
Copy link
Contributor Author

I fix the description and add touch level. All examples are tested and work.

Если такие классы проекту не нужны, можно переопределить `BEMHTML` шаблон блока `ua`
на уровне переопределения проекта:
Если такой класс проекту не нужен, можно переопределить `BEMHTML` шаблон блока `ua`
на уровне проекта:

```js
block('ua').default()()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Murdalay проверял ли ты этот кейс?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tadatuta кейс с BH также требует освещения

@Murdalay
Copy link
Contributor Author

Fixed. I've remove the example – it just sets js to no, so it's not very useful.

tadatuta added a commit that referenced this pull request Feb 12, 2015
ua block Russian description Close #779
@tadatuta tadatuta merged commit 69cdecf into v2 Feb 12, 2015
@tadatuta tadatuta deleted the issues/#779@v2 branch February 12, 2015 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants