add option write to testdata instead of __snapshots__?
#37
Comments
|
@b5 thanks! And I'm totally for it. Send a PR! And just thinking through release.... better to support existing workflow or make this the new standard? Seems if this is the idiomatic way, it should also be standard. In any case, let's go for it & we can eventually transition to it being the standard. |
b5
added a commit
to b5/abide
that referenced
this issue
May 1, 2018
This let's users adjust the behaviour of abide's interaction with the filesystem, exporting Snapshot Dir & Ext variables. I've adjusted the LoadSnapshots function to directly set the internal allSnapshots variable (this is the only way loadSnapshots was being used). This is intentended as a short-ish term stopgap, allowing users to adjust vars like SnapshotDir then call LoadSnapshots() to have these changes take effect. I've added documentation of this to the readme.md. closes beme#37
b5
added a commit
to b5/abide
that referenced
this issue
May 1, 2018
This let's users adjust the behaviour of abide's interaction with the filesystem, exporting Snapshot Dir & Ext variables. I've adjusted the LoadSnapshots function to directly set the internal allSnapshots variable (this is the only way loadSnapshots was being used). This is intended as a short-ish term stopgap, allowing users to adjust vars like SnapshotDir then call LoadSnapshots() to have these changes take effect. I've added documentation of this to the readme.md. closes beme#37
b5
added a commit
to b5/abide
that referenced
this issue
May 1, 2018
This let's users adjust the behaviour of abide's interaction with the filesystem, exporting Snapshot Dir & Ext variables. I've adjusted the LoadSnapshots function to directly set the internal allSnapshots variable (this is the only way loadSnapshots was being used). This is intended as a short-ish term stopgap, allowing users to adjust vars like SnapshotDir then call LoadSnapshots() to have these changes take effect. I've added documentation of this to the readme.md. closes beme#37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Fantastic tool! Love bringing react concepts into go land 😄.
While go tool has special treatment for directories & filenames that start with
.,_, ortestdata, thetestdatadirectory it's considered by some to be idiomatic. I know it's a totally irate thing, but would it be great if I could chose to write snapshots totestdata/__snapshots_. One way might be to export the default hardcoded snapshots var. I'd be happy to submit a PR if you're ok with the idea!The text was updated successfully, but these errors were encountered: