Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert http requests #42

Merged
merged 3 commits into from
Jul 25, 2018
Merged

Conversation

alexhornbake
Copy link
Contributor

I found myself needing to test some outgoing client http requests. Imagine a "MockService" and a http client library that has a function like func (c *client) BuildServiceRequest() *http.Request { ... }

Anyway. This adds some helpers to make that a little easier.

@sjkaliski What do you think? Useful?

@sjkaliski
Copy link
Collaborator

@alexhornbake 👋

Seems useful and overdue :)

@sjkaliski
Copy link
Collaborator

Looks like just a couple linting errors and then good to go 👍

@alexhornbake
Copy link
Contributor Author

@sjkaliski 👋nice linter 👍 should be all set now.

@sjkaliski sjkaliski merged commit 1970c2b into beme:master Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants