Remove '\r' from data before splitting with '\n' #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to RFC 2616 (section 2.2) the HTTP header line break is '\r\n', causing issues when splitting only by '\n'. The remaining '\r' special characters were not matching with the snapshot.
|
This issue occurs because git replaces the @sjkaliski Have you ever had any problem with that? |
|
Solved this issue adding a config in With that git will not try to change the line break. |
|
This also fixed my issue. It was working locally but when checked in and ran on Travis, it would fail. Since this is probably so common for folks who use git, should this be added to the README file? |
|
@amir20 Yeah, I think it would be great to have this on README. 👍 |
|
@amir20 @rafaeljusto PRs welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 2616 (section 2.2) the HTTP header line break is '\r\n', causing issues when splitting only by '\n'. The remaining '\r' special characters were not matching with the snapshot.