Replace eslint-config-cssnano with xo #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rejas
reviewed
Mar 7, 2021
src/__tests__/test.js
Outdated
| '<circle cx="50" cy="50" r="40" fill="yellow" />' + | ||
| '<!-- test comment --></svg>'; | ||
| const doctype = | ||
| '<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">'; |
There was a problem hiding this comment.
Maybe increase the printwidth (via prettierrc) so that the diff doesnt have so much linewraps?
There was a problem hiding this comment.
Possibly better might be to move these fixtures out into svg files and read them in from the test instead?
There was a problem hiding this comment.
@rejas Done, note that whitespace is controlled by xo --fix for now rather than prettier --write. I'd like at some point to get this all automated if possible. 👍
rejas
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to deprecate https://github.com/ben-eb/eslint-config-cssnano if possible as I can't spare the time to maintain it. 🙂