-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle 5.0-rc-1: ComponentSelectionRules.all(Closure) with injection of ComponentMetadata and/or IvyModuleDescriptor has been deprecated #270
Comments
This error message also happens when using Gradle 5.1.1 |
And 5.2.1 |
And 5.3-rc-3 |
And this will not change until Gradle 6 where the used method will be deleted, so what's the point in listing all the Gradle versions here? o_O |
To make enough noise that a developer god like you come across and open a pull request @Vampire :P |
I'm no god and I didn't even hear that noise, just found the issue I fixed already being reported. |
Then GitHub should implement a Subscription Count. |
Subscription is not equal to voting, you can also watch what you are against. |
Thanks @Vampire for the PR! |
Just as an FYI, Gradle 6.0 will be the next version after Gradle 5.6. As expected, this plugin without this change will not run on it. I looked for that information elsewhere but could not find it. |
Okay, I kicked off the CI build to release it (automatically on a new release tag). |
Should we care about the |
Ok, something else broke too anyway |
hmm, I wonder if it is due to |
I can't reproduce the failure locally, so retriggered the CI. It might be a flaky test. |
This time it succeeded. I guess we need to investigate why tests are flaky. They make some external calls (e.g. to Gradle release channel) which might have caused some pain. |
And the |
No clue... it might have been an interaction with the buildscan introspection? |
Using Gradle 5.0-rc-1 I get this message: The method ComponentSelectionRules.all(Closure) with injection of ComponentMetadata and/or IvyModuleDescriptor has been deprecated. This is scheduled to be removed in Gradle 6.0. Use the new methods on ComponentSelection instead.
The according stacktrace is:
The text was updated successfully, but these errors were encountered: