You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
When upgrading Filtration to a new version on a system that does not have the default POE user data directory present at C:\Users\<username>\Documents\My Games\Path of Exile, the user is incorrectly prompted to select their POE data directory.
This occurs because ItemFilterPersistenceService has the following code in its constructor:
As this is in the constructor, it runs during IoC container dependency resolution, which occurs before the settings migration for a new version has run. Therefore, the settings file it reads has the default settings instead of the migrated settings.
The fix for this is to make ItemFilterPersistenceService.ItemFilterScriptDirectory use a Lazy<string> backing field so that it is evaluated the first time it's called rather than during construction.
The text was updated successfully, but these errors were encountered:
When upgrading Filtration to a new version on a system that does not have the default POE user data directory present at
C:\Users\<username>\Documents\My Games\Path of Exile
, the user is incorrectly prompted to select their POE data directory.This occurs because
ItemFilterPersistenceService
has the following code in its constructor:ItemFilterScriptDirectory = Settings.Default.DefaultFilterDirectory;
As this is in the constructor, it runs during IoC container dependency resolution, which occurs before the settings migration for a new version has run. Therefore, the settings file it reads has the default settings instead of the migrated settings.
The fix for this is to make
ItemFilterPersistenceService.ItemFilterScriptDirectory
use aLazy<string>
backing field so that it is evaluated the first time it's called rather than during construction.The text was updated successfully, but these errors were encountered: