Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Upgrading to a release when default POE user data directory does not exist results in prompt #139

Open
ben-wallis opened this issue Sep 11, 2019 · 2 comments
Labels

Comments

@ben-wallis
Copy link
Owner

When upgrading Filtration to a new version on a system that does not have the default POE user data directory present at C:\Users\<username>\Documents\My Games\Path of Exile, the user is incorrectly prompted to select their POE data directory.

This occurs because ItemFilterPersistenceService has the following code in its constructor:

ItemFilterScriptDirectory = Settings.Default.DefaultFilterDirectory;

As this is in the constructor, it runs during IoC container dependency resolution, which occurs before the settings migration for a new version has run. Therefore, the settings file it reads has the default settings instead of the migrated settings.

The fix for this is to make ItemFilterPersistenceService.ItemFilterScriptDirectory use a Lazy<string> backing field so that it is evaluated the first time it's called rather than during construction.

@ben-wallis ben-wallis added the bug label Sep 11, 2019
@synicasm
Copy link

synicasm commented Oct 2, 2019

Getting this as well on a fresh install. I'm guessing its the same issue.

Some info on this PC's state..
Had Path Of Exile installed
Removed Path of Exile.
Noticed the Path of Exile folder in My Games.
Deleted the folder.

Filtration Gives Various errors trying to create a new filter or open an existing one...

Same Path Error...
C:\Users<username>\Documents\My Games\Path of Exile

@synicasm
Copy link

synicasm commented Oct 2, 2019

Anyone else running into this issue.

Simply adding a folder for Path of Exile seems to satisfy it for now.
C:\Users\Documents\My Games\Path of Exile

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants