-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glob stays in the tree's root path #88
Comments
What would you expect in cases like "**" or any other more open glob then? The cli shows that the user inputted and what the result of that input was. |
Yes you're right, I haven't thought about that. We will keep it that way then. |
The alternative would be to show the shared parent |
@benawad That is somewhat confusing when folders are ignored. It would look like we want to remove them. |
I'd say we have two alternatives. Either we keep it like it currently works or when a glob is inputted we get all root paths of that glob. That would probably be pretty clear to the user. |
What about something like this:
|
I like it |
fix: Glob stays in the tree's root path - #88
I fixed the log with the glob pattern. How do you see the implementation of the ignored files? I need some more information before this could actually be implemented.
Perhaps we need to make another issue since it looks more like a feature then a bug? |
@SimonJang It would be nice if all the cases you described are logged as ignored files/folders. We will keep this issue for now, I've changed the labels. |
The root file of the tree is
src/**/*.*
, it should probably be a simplesrc
.The text was updated successfully, but these errors were encountered: