Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make /notes/:guid work better with other clients #114

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ringtailsoftware
Copy link
Contributor

@ringtailsoftware ringtailsoftware commented Jan 13, 2023

Return HTTP 404 for /note/non-existent-guid
Return raw ActivityPub JSON for /note/:guid when HTTP Accept header contains "application/activity+json", so clients can get the raw document and render it how they want. For example, this allows a /note/:guid link to be pasted into the search box on a Mastodon instance

Return raw ActivityPub JSON for /note/:guid when HTTP Accept header contains "application/activity+json", so clients can get the raw document and render it how they want
@benbrown
Copy link
Owner

Interesting. There is already a /n/:guid url that is supposed to be the canonical json url, but I would rather there just one and have it be this one. So great!

@benbrown
Copy link
Owner

@ringtailsoftware This works as expected, but I am not able to get it to load in the Mastodon search results.

I am watching the traffic - I see it return the JSON as expected to the incoming request from Mastodon. But Mastodon returns no results in the search.

Any ideas?

@benbrown
Copy link
Owner

@ringtailsoftware any perspective on this?

@ringtailsoftware
Copy link
Contributor Author

I had thought it fixed search, but perhaps not. Maybe search was working because the server had already seen the post.

@benbrown benbrown added the wont-merge indicates this PR will not be merged label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wont-merge indicates this PR will not be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants