Refactor project python -> ruby #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This project has been stale for a while, which is largely due to a number of poor decisions made when developing the project. Namely: - The user creation process was overly complicated - The project had an unconventional python set up that was unnecessarily compensated for in the setup script - The run script was fairly clunky - There was no testing of any kind - The backend mostly just consisted of a single "god file", and relied heavily on third party libraries, which were imported haphazardly All of these and more are fixed with this refactor, which will hopefully allow me to revisit this project and give it more attention. The code is a lot simpler now, and has a fair amount of testing to ensure that basic functionality and routing works as expected. It will probably never be able to test the GPIO functionality (since that's hard to do without a physical device) and the video streaming functionality (since a lot of that is reliant on Janus). Eventually this could be expanded on to also run the setup script, once that has been updated to not have any need for user interaction. The previous python implementation will be frozen into branch "python". For anyone curious about this refactoring, feel free to reach out to me to learn more. I'm also planning on writing a blog post about my reasoning behind the language change.
The preference for this project is double quotes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project has been stale for a while, which is largely due to a
number of poor decisions made when developing the project. Namely:
compensated for in the setup script
heavily on third party libraries, which were imported haphazardly
All of these and more are generally fixed with this refactor, which will
hopefully allow me to revisit this project and give it more attention.
The code is a lot simpler now, and has a fair amount of testing to
ensure that basic functionality and routing works as expected. It will
probably never be able to test the GPIO functionality (since that's hard
to do without a physical device) and the video streaming functionality
(since a lot of that is reliant on Janus).
Eventually this could be expanded on to also run the setup script, once
that has been updated to not have any need for user interaction.
The previous python implementation will be frozen into branch "python".
For anyone curious about this refactoring, feel free to reach out to me
to learn more. I'm also planning on writing a blog post about my
reasoning behind the language change.