Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance metadata from original sources if possible #500

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

stufisher
Copy link
Contributor

@stufisher stufisher commented Jan 4, 2021

I've tried to isolate the interaction with other services. Enhanced metadata can be enabled by setting ENHANCE_METADATA=true in your env. Works for currently playing and things in the queue.

Some feedback on this would be useful, there are likely things i dont understand about how album art urls are generated, maybe there is a way to dynamically retrieve the radio art url?

@svrooij
Copy link
Collaborator

svrooij commented Mar 17, 2021

I like the idea to do this, why isn't sonos doing this by itself?

Apart from that, this seems like something that is perfectly testable. Can you create a test for loading the info for some random soundcloud track?

And I see that it’s no longer possible to create a client Id for SoundCloud, but do you really need a separate library just to scrape the client id? A regular expression would be sufficient I guess?

how does this relate to accessing the external music service data directly, like described here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants