Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install copt through pip rather than github #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mathurinm
Copy link
Contributor

For me it's more stable to install package through pip when they are available on PyPI. At least this works on my machine while the version on main fails.
@tomMoral

Copy link
Contributor

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume copt has indeed been released now

@mathurinm
Copy link
Contributor Author

tests are not run ? I don't see anything suspicious in the workflow, the branch name is updated to main

Maybe I need to be approved @tomMoral ?

@agramfort agramfort closed this Nov 24, 2021
@agramfort agramfort reopened this Nov 24, 2021
@agramfort
Copy link
Contributor

I tried to close/open to start CIs but no success...

@agramfort agramfort closed this Nov 24, 2021
@agramfort agramfort reopened this Nov 24, 2021
@tomMoral
Copy link
Member

The pypi version is too old and does not have the loss module.
I think @agramfort is the one who used the latest version from github, not sure why but I woud keep it like that so we don't have to change for the next release cycle.

Overall, I agree that using a version released to pypi is better than using master as it is more stable.

@mathurinm mathurinm closed this Mar 29, 2022
@mathurinm mathurinm reopened this Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants