-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fakefish data #34
Fakefish data #34
Conversation
…parameters. Still need to work on wave-fish.
data = np.sin(2 * np.pi * time * freq) | ||
for har in range(harmonics): | ||
if har > 1: | ||
data += (np.sin(2*np.pi*time*(har*freq))) * 0.1*har |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simpler:
for har in range(1, harmonics):
data += ...
Hi Juan, thank you for starting to implement this! I put some technical comments into the code... Once you implemented this we will merge it. I like the wavefish with the n harmonics. I might make this more general And then I will add Apteronotus and Eigenmannia. Likewise we should add Jan On 06/30/2016 11:25 AM, Juan F. Sehuanes wrote:
Prof. Dr. Jan Benda |
I created a Fakefish module. So far it only has a pulse-fish and a wave-fish. We might want to add more things to it (s.a. different species like Eigenmania), but this should be fine for what we need it now i.e. the TESTS!
please review and add suggestions!