Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fakefish data #34

Merged
merged 5 commits into from
Jun 30, 2016
Merged

Fakefish data #34

merged 5 commits into from
Jun 30, 2016

Conversation

jfsehuanes
Copy link
Contributor

I created a Fakefish module. So far it only has a pulse-fish and a wave-fish. We might want to add more things to it (s.a. different species like Eigenmania), but this should be fine for what we need it now i.e. the TESTS!

please review and add suggestions!

data = np.sin(2 * np.pi * time * freq)
for har in range(harmonics):
if har > 1:
data += (np.sin(2*np.pi*time*(har*freq))) * 0.1*har
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simpler:
for har in range(1, harmonics):
data += ...

@janscience
Copy link
Collaborator

Hi Juan,

thank you for starting to implement this!

I put some technical comments into the code...

Once you implemented this we will merge it.

I like the wavefish with the n harmonics. I might make this more general
by supplying relative amplitudes andnphases for each harmonics.
Similar for the pulse fish we might supply amplitudes, relative position
and width (standard deviation) for n gaussian pulses.

And then I will add Apteronotus and Eigenmannia. Likewise we should add
some standard mono- and biphasic pulse fish.

Jan

On 06/30/2016 11:25 AM, Juan F. Sehuanes wrote:

I created a Fakefish module. So far it only has a pulse-fish and a
wave-fish. We might want to add more things to it (s.a. different
species like Eigenmania), but this should be fine for what we need it
now i.e. the TESTS!

please review and add suggestions!


    You can view, comment on, or merge this pull request online at:

#34

    Commit Summary


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#34, or mute the thread
https://github.com/notifications/unsubscribe/ALfehO3pOmF3_Ik3duGE32cMyQrUW5e3ks5qQ4twgaJpZM4JB9zW.


Prof. Dr. Jan Benda
Abteilung Neuroethologie
Institut fuer Neurobiologie
Universitaet Tuebingen
Auf der Morgenstelle 28 E phone: +49 / 7071 - 29 74573
72076 Tuebingen fax: +49 / 7071 - 29 5144


@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 13.497% when pulling a7b55b1 on jfsehuanes:fakefish_data into a97365a on bendalab:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 13.55% when pulling c9775e6 on jfsehuanes:fakefish_data into a97365a on bendalab:master.

@janscience janscience merged commit 3f032ee into bendalab:master Jun 30, 2016
@jfsehuanes jfsehuanes deleted the fakefish_data branch June 30, 2016 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants