generalized fake fishes #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| data = np.zeros(len(time)) | ||
| if np.isscalar(amplitudes): | ||
| amplitudes = [amplitudes] | ||
| for har, ampl in enumerate(amplitudes): |
There was a problem hiding this comment.
I don't understand what you mean with amplitudes... but perhaps a live explanation is more successful.
|
Nice updates on the module! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I generalized Juans generate_wavefish() and generate_pulsefish() functions, added a few specialized functions for specific fishes and extended the docu.
I also simplified the plotting in fakefish main. We should keep the example plots in the main functions as simple as possible. No special colors, alphas, fontsizes, etc. These are examples that other people might want to use to adapt them to their own purposes. They might not care about our lates fancy plot styles.