We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cookie-parser populates req.cookies (plural) and plugToRequest incorrectly checks req.cookie (singular).
cookie-parser
req.cookies
plugToRequest
req.cookie
Parse Cookie header and populate req.cookies with an object keyed by the cookie names.
https://github.com/expressjs/cookie-parser
function plugToRequest(req, res) { if (req.cookie) { _rawCookie = req.cookie; } else if (req.headers && req.headers.cookie) { setRawCookie(req.headers.cookie); } else { _rawCookie = {}; } _res = res; }
https://github.com/eXon/react-cookie/blob/master/index.js#L67-L77
Not really breaking since req.headers.cookie is a fallback and that exists but I thought I would point it out.
req.headers.cookie
The text was updated successfully, but these errors were encountered:
Add test for express cookies request property
664c206
Relate #18
Fix cookie-parser populates req.cookies (plural)
3d03d01
Fix #18
803d178
Merge pull request #22 from pjvds/master
5f418cd
Fix #18 cookie-parser populates req.cookies (plural)
No branches or pull requests
cookie-parser
populatesreq.cookies
(plural) andplugToRequest
incorrectly checksreq.cookie
(singular).https://github.com/expressjs/cookie-parser
https://github.com/eXon/react-cookie/blob/master/index.js#L67-L77
Not really breaking since
req.headers.cookie
is a fallback and that exists but I thought I would point it out.The text was updated successfully, but these errors were encountered: