Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Rectangle Shape #15

Closed
NickAtGit opened this issue Jul 22, 2024 · 1 comment · Fixed by #17
Closed

Configurable Rectangle Shape #15

NickAtGit opened this issue Jul 22, 2024 · 1 comment · Fixed by #17

Comments

@NickAtGit
Copy link

The package looks interesting, thanks for making it. But so far I'm just seeing circle and square as shapes. I would like to pass the width and height to the package to define my rectangle. Are there any technical limitations why you didn't build that?

@benedom
Copy link
Owner

benedom commented Jul 23, 2024

Hi, the reason for this is that those are the most commonly used shapes when cropping images. When I built this library, the requirements were for these shapes only.
There is already an issue that connects to your question: #12

I tried working on it but had to pause development due to time constraints. The cropping needs to be adjusted with a new calculation of the cropping area, which is a bit complicated.

Feel free to take over the issue if you want and submit a PR if you manage to build it!

@benedom benedom linked a pull request Aug 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants