Fix sys.platform #29
Closed
Fix sys.platform #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the pull request. Could you open an issue describing the behavior you are seeing and how this fixes it? And could amend the commit message to either reference that issue or briefly describe it? |
|
Thanks for the review. Referenced the issue #28 in the commit message |
|
Okay, now that I understand from the issue what you're trying to do, I would ask you to add one thing: At environment creation time, we need to recognize that build sys.platform != host sys.platform and issue a warning that this is not a supported use case. |
|
This doesn't work. Monkeypatching |
|
Ah, I was afraid of that. Thanks anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.